Differential D4571

Fix adding files to data project
ClosedPublic
Actions

Authored by broulik on Feb 11 2017, 3:53 PM.

Details

Reviewers
davidedmundson
jriddell
lesliezhai
Group Reviewers
Plasma
Commits
R467:d21096fa6e10: Fix adding files to data project
Summary

In cf01ff3159dbddb97e0e67246dee16441a64984a this broke by randomly using QSharedPointer in the wrong way.
There was only this one item being referenced, once it fell out of scope it got deleted, and then by the time the event loop returned and the queued invocation was processed, the object was already gone.

Just use WA_DeleteOnClose which will clean up nicely once we're done.

BUG: 375016

Test Plan

FIXED-IN: Whatever stable branch and stuff this is in, I'll figure it out.

I can now add files to K3B projects again.

Diff Detail

Repository
R467 K3b
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 11226.Feb 11 2017, 3:53 PM
broulik retitled this revision from to Fix adding files to data project.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: lesliezhai, jriddell, Plasma.
broulik set the repository for this revision to R467 K3b.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 11 2017, 3:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Feb 11 2017, 3:58 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Feb 11 2017, 3:58 PM
lesliezhai edited edge metadata.Feb 13 2017, 1:26 AM

Hi Kai Uwe,

Thanks a lot for the fix!

And I will try to fix clang analyzer's false positive ;-)

Regards,
Leslie Zhai

Revision Contents
Changeset List

Diff 11226

View Options

src/projects/k3bdataurladdingdialog.cpp

Loading...