[UDisks 2 Device] Add description for Floppy Disk
ClosedPublic

Authored by broulik on Feb 11 2017, 3:15 PM.

Details

Summary

Ensures a floppy disk shows up as "Floppy Disk" instead of "0 Byte Removable Media"

Test Plan

Never actually reports any size so I didn't bother with the size thing and the code around is wrong anyway, it's like
if (!sizeString.isEmpty()) but formatSize always returns something, even if it is 0 B

Before

After

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik retitled this revision from to [UDisks 2 Device] Add description for Floppy Disk.Feb 11 2017, 3:15 PM
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, jriddell.
broulik set the repository for this revision to R245 Solid.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 11 2017, 3:15 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Feb 11 2017, 3:18 PM
jriddell accepted this revision.Feb 11 2017, 3:31 PM

Genius, this solves the final problem in KDE and will be a killer feature in the next Frameworks release

This revision is now accepted and ready to land.Feb 11 2017, 3:31 PM
This revision was automatically updated to reflect the committed changes.