Differential D4562

Only export the org.kde.keyboard DBus service if there are at least two layouts
ClosedPublic
Actions

Authored by graesslin on Feb 11 2017, 10:37 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
KWin
Commits
R108:40de5fa75fdd: Only export the org.kde.keyboard DBus service if there are at least two layouts
Summary

It doesn't make much sense to export the DBus service if there is nothing
one can do with it.

Test Plan

Added test case

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 11204.Feb 11 2017, 10:37 AM
graesslin retitled this revision from to Only export the org.kde.keyboard DBus service if there are at least two layouts.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptFeb 11 2017, 10:37 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Feb 11 2017, 10:40 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Feb 11 2017, 10:40 AM
Closed by commit R108:40de5fa75fdd: Only export the org.kde.keyboard DBus service if there are at least two layouts (authored by graesslin). · Explain WhyFeb 11 2017, 10:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11205

View Options

autotests/integration/keyboard_layout_test.cpp

Loading...
View Options

keyboard_layout.h

Loading...
View Options

keyboard_layout.cpp

Loading...