Differential D4559

Clean GCodeWidget
ClosedPublic
Actions

Authored by laysrodrigues on Feb 10 2017, 11:40 PM.

Details

Reviewers
tcanabrava
rizzitello
patrickelectric
Commits
R231:ddcfea7891e5: Clean GCodeWidget
R231:e4f0b8d20b72: Add KXMLGuiFactory
R231:7b92878576b3: Remove ui file
R231:9f53a2e21d31: Clean GCodeWidget
R231:3e408d3ed980: Refactor of GCodeWidget
R231:81338a0f2182: Added KTextEditor to GCodeWidget
R231:5864e8c73d4f: Add a separator
R231:ac15572912b6: Re-Implement GCodeEditor
Summary

Removed all widgets... Plan: Substitute to KTextEditor

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Added KTextEditor to GCodeWidget

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Re-Implement GCodeEditor

  • Used KTextEditor to implement GCodeEditor
  • Added PushButtons to be a toolbar with actions. Still

need to discover how to implement redo and undo

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Adapt MainWindow to use the new GCodeEditor

Made the necessary updates so MainWindow can work
with GCodeEditor.

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Repository
R231 Atelier
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
laysrodrigues updated this revision to Diff 11198.Feb 10 2017, 11:40 PM
laysrodrigues retitled this revision from to Clean GCodeWidget.
laysrodrigues updated this object.
laysrodrigues edited the test plan for this revision. (Show Details)
laysrodrigues added reviewers: rizzitello, patrickelectric, tcanabrava.
patrickelectric added inline comments.Feb 11 2017, 2:30 AM
src/widgets/gcodeeditorwidget.cpp
21

Is it necessary ?

laysrodrigues added inline comments.Feb 11 2017, 1:58 PM
src/widgets/gcodeeditorwidget.cpp
21

Not anymore. Thanks for remember =D

laysrodrigues updated this revision to Diff 11221.Feb 11 2017, 2:31 PM

Remove unnecessary includes

rizzitello edited edge metadata.Feb 13 2017, 1:34 PM

Looks much better .

  1. Can we solve the issue of needing to be installed to show the widget?
src/widgets/gcodeeditorwidget.ui
1

Can we remove this UI file and do this within code (please)
If needed i can provide a patch for your diff to do so

laysrodrigues updated this revision to Diff 11656.Feb 23 2017, 2:51 AM
  • Refactor of GCodeWidget
  • Add a separator
  • Add KXMLGuiFactory
rizzitello added a comment.Feb 23 2017, 12:17 PM

This is to remove the UI file...
Please do so and test to see its still the same

src/widgets/gcodeeditorwidget.cpp
19

Remove

24

Remove

26

Remove

30

view = doc->createView(this);

OR

view = doc->createView();

31

remove

33

this->setLayout(layout);

src/widgets/gcodeeditorwidget.h
22

remove

36

remove

src/widgets/gcodeeditorwidget.ui
1

remove

laysrodrigues updated this revision to Diff 11732.Feb 23 2017, 11:23 PM
  • Remove ui file
rizzitello accepted this revision.Feb 23 2017, 11:28 PM
rizzitello added inline comments.
src/mainwindow.h
27 ↗(On Diff #11732)

Blank line? if so please remove.

This revision is now accepted and ready to land.Feb 23 2017, 11:28 PM
Closed by commit R231:9f53a2e21d31: Clean GCodeWidget (authored by laysrodrigues). · Explain WhyFeb 24 2017, 4:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11735

View Options

src/mainwindow.cpp

Loading...
View Options

src/widgets/gcodeeditorwidget.h

Loading...
View Options

src/widgets/gcodeeditorwidget.cpp

Loading...
View Options

src/widgets/gcodeeditorwidget.ui

Loading...