Differential D4552

[PreviewJob] Remove maximum size for local files by default
ClosedPublic
Actions

Authored by broulik on Feb 10 2017, 4:40 PM.

Details

Reviewers
emmanuelp
hein
dfaure
Commits
R241:a942db1a0dd5: [PreviewJob] Remove maximum size for local files by default
Summary

Dolphin already special-cased this and removed the UI configuration for it.
This meant that you would never get previews for larger files anywhere else, especially noticeable in FolderView.

Test Plan

I now get previews for large PDF files on my desktop, once I enabled the PDF thumbnailer (selection of default previewers is a discussion for another time…)
It can still be configured, if so desired, by using

[PreviewSettings]
MaximumSize=...

(probably needs some obscure #include for some compilers again…)

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 11185.Feb 10 2017, 4:40 PM
broulik retitled this revision from to [PreviewJob] Remove maximum size for local files by default.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: dfaure, emmanuelp, hein.
broulik set the repository for this revision to R241 KIO.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 10 2017, 4:40 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Feb 10 2017, 4:42 PM
hein accepted this revision.Feb 11 2017, 8:33 AM
hein edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2017, 8:33 AM
dfaure edited edge metadata.Feb 21 2017, 4:02 PM

No objection.

Closed by commit R241:a942db1a0dd5: [PreviewJob] Remove maximum size for local files by default (authored by broulik). · Explain WhyFeb 21 2017, 4:30 PM
This revision was automatically updated to reflect the committed changes.
abika added a subscriber: abika.May 14 2017, 2:14 PM

File preview is also used in Krusader. Please add us to subscribers for behaviour changes. Thanks.

dfaure added a comment.May 14 2017, 3:04 PM

In that case you might want to look at the fixes I just committed for https://bugs.kde.org/show_bug.cgi?id=208625

Revision Contents
Changeset List

PathPackages
Msrc/widgets/previewjob.cpp (4 lines)

Diff 11592

View Options

src/widgets/previewjob.cpp

Loading...