After an update to Plasma 5.9 in KDE Neon, ksshaskpass stop working.
After diging a little on the web, I found that this bug "https://www.mail-archive.com/kde-bugs-dist@kde.org/msg117934.html"
was the problem and I fixed.
Details
- Reviewers
mpyne whiting bbuch cfeck - Commits
- R105:408c284f6a35: Fix git ssh password detection
Diff Detail
- Repository
- R105 KDE SSH Password Dialog
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Thanks, this looks good so far, but adding more eyes, because it touches privacy sensitive code.
One issue: The comments for the change that broke this state that 'sshaskpass' has no translations, so the prompt is the same in any locale.
Could you verify if 'git' uses the same prompt in any language/locale?
I could not tell, I've tried changing git's language/locale but apparently there is no easy way to do that.
This doesn't work for Usernames and the resulting keyFile is different from the old behavior. (It contains the closing ": ")
Please change the regular expression to:
QRegularExpression re3("^(Password|Username) for (.*?)[:] $");
and map the keyFile to:
keyFile = match3.captured(2);
Apart from that, thank you very much, great work! :-)
I use git with german locals and it does work.
- changes requested by bbuch
- Updating D4540: fix bug with git after update to Plasma 5.9 in neon #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
change regex to also capture username and comply with old behavior
The change is fine as far as privacy impact, it shouldn't add any issues that aren't already present.
The duplicate bug 376318 does not mention 'git', but simply opening a (secure) shell. Do both use the same 'ssh-add' command? If yes, then the comment mentioning 'git' might be misleading.
Can you change the commit title and message to be a little more descriptive than "fix bug after git update to 5.9", like "Fix password extraction from blabla"
- Updating D4540: Fix password extraction from git after update to Plasma 5.9 in neon #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
Fix password extraction from git after update to Plasma 5.9 in neon
This bug caused ksshaskpass to ask for the password and/or username every time without storing it in kwallet
This is my first time using this tool, I am so sorry, I was trying to change the commit message.
Use "Update Diff" to upload the correct diff. If you switched between different branches (as the current diff suggests), please make sure you solve the git issues first. If everything else fails, "git reset origin/master", and re-apply your changes.
Fix password extraction from git after update to Plasma 5.9 in neon
This bug caused ksshaskpass to ask for the password and/or username every time without storing it in kwallet
src/main.cpp | ||
---|---|---|
62 | So are these strings really specific to git? Also, it makes no sense to mention the Plasma version or distribution this bug appears, if you want some explanation, either add the specifics in the comment, or just reference the KDE bug number. |
- Fix password extraction from git. bug number 376228
- remove Plasma version and distribution from comment
I suppose that it could work for other apps as well but I only use this program for git
Thanks, looks good now. Do you have commit rights? If not, I will commit it on your behalf.