Apparently in Qt 5.8 the implicit sizes now take into account padding but since we want to support 5.7 (?) makes sense.

Mentioned in the changelog: https://code.qt.io/cgit/qt/qtquickcontrols2.git/tree/dist/changes-5.8.0

You sure this doesn't break anything if you mess with anchors and sizes and don't have a wrapper Item around it?

I think with QtQuick 2 smooth doesn't matter anymore, other than making it look worse.

From docs

In Qt Quick 2.0, this property has minimal impact on performance.

Docs say

You can also enable or disable hover effects for all Qt Quick Controls 2 applications by setting the QT_QUICK_CONTROLS_HOVER_ENABLED environment variable.

What Label is this? I don't see any import/namespace that would provide this here

QQC2 Label supposedly supports font (and probably other) inheritance

Now that we have activeFocusReason we could potentially behave differently whether it was user-focused or tab-focused (not now but keeping that in mind for the future)

in-window Popup makes me sad :(

Do we really want a ListView here?

Also, how does it work with e.g. HelpRole and things that would go on the left rather than the right? Dunno if it supports that though

Math.round(units.devicePixelRatio) instead of 1?

Hardcoded number

I don't get why we check background here and in other places. It would only be null if a user subclassed this and then overwrote the property to undefined, at which point they deserve errors.

we do someting differently for widths and heights which isn't ideal, can we move the units.gridUnit * 1.6 into here as an implicitHeight?

why?

booo!

Now we have an API break, lets fix this.

As soon as you put this in a layout it won't do anything, so it's quite inconsistent.
If anything it should be an implicitHeight, or just set the lineHeight?

But I'd rather we didn't have it at all, we have to work round it in lots of places.

If we want a padded Label, we can make a new subclass in the import with all the other headings.

Bhushan did a patch for P-F that changed this on the current label if we're on mobile, is that still possible?

can we kill an item here?

background: FrameSvgItem {

TextFiledFocus {
    anchors.fill:parent
 }

}

maybe we don't want:

ToolTip, Popup, Dialog, DialogButtonBox here and only in the style?

Also which is the "correct" ItemDelegate we have one of them in PlasmaExtras

typo

It's easier to add something later than to remove it.

I'd go with not installing for now, then revisit it. Maybe same for Menus.

I still want this changed.

Dialog and DialogButtonBox are listed here but aren't installed. I think that will cause an error.

And do we need CheckIndicator here?

It probably made sense when it was written, but your comments about layouts is outdated.

No manual changes are needed.

try:
https://paste.kde.org/pgi2ui6e3

If it was a problem we'd be seeing it all the time in the config modules.

It is true for manual positioning and anchors, but I think the vast majority of the time where we'd want to be aligned to a button we'd be in a layout with that button.

I'm sure there will be some changes needed, but it'll be few. (if I remove the line in my QQC1 label locally, I can't see any)

In constrast run this on your workspace folder:
find -name '*.qml' | xargs grep 'height:' | grep paintedHeight

and you'll see the number of times we have to reverse this logic.

so, GridLayout and RowLayout align correctly, while Row still doesn't.

so, ok for me to remove it, and require *layouts are used instead of simple positioners everywhere