Binary clock QML applet
ClosedPublic

Authored by davidedmundson on Feb 8 2017, 2:32 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R114:990d291b8daf: Binary clock QML applet
Summary

Patch by Joseph Wenninger

Taken from: https://git.reviewboard.kde.org/r/120325/

Test Plan

Seems to work quite well; only issue is it goes into compact mode in a
Panel a bit prematurely. Rest looks fine.

Diff Detail

Repository
R114 Plasma Addons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson retitled this revision from to Binary clock QML applet.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 8 2017, 2:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 8 2017, 5:39 PM
mart added a reviewer: mart.
mart added a subscriber: mart.
mart added inline comments.
applets/binary-clock/package/contents/ui/BinaryClock.qml
41

this should be in gridunits?

45

pretty arbitrary?

This revision is now accepted and ready to land.Feb 8 2017, 5:39 PM
Closed by commit R114:990d291b8daf: Binary clock QML applet (authored by Joseph Wenninger <kde@jowenn.at>, committed by davidedmundson). · Explain WhyMay 1 2017, 12:52 PM
This revision was automatically updated to reflect the committed changes.