- Don't exit application if KDBusService has failed.
- Don't confuse Windows\system32\convert.exe utility with ImageMagick's one.
Details
Details
- Reviewers
mludwig - Group Reviewers
Kile - Commits
- R468:9b2b4478263f: Windows fixes:
"System Check" now works on Windows and all-green with MikTeX installed.
Diff Detail
Diff Detail
- Repository
- R468 Kile
- Branch
- windows_fixes (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/configtester.cpp | ||
|---|---|---|
| 132 | I find it a little surprising that a distinction is necessary here. What location is returned for QStandardPaths::DataLocation? Can you try to use to use QStandardPaths::AppDataLocation? | |
| src/main.cpp | ||
| 147 | Do you know what the status of dbus for Windows is? Running two instances of Kile is actually quite risky when it comes to configuration changes. | |
| src/configtester.cpp | ||
|---|---|---|
| 132 | From the official docs:
That "test" dir ends up in "data/kile" because ECM sets KDE_INSTALL_DIR or whatever that variable is called to "bin/data/<APPNAME>" on Windows. Not sure who is wrong there, but many other apps are working somehow. Using AppDataLocation wouldn't help there, as it differs only in "Local" part. | |
| src/main.cpp | ||
| 147 | Hum, well, I'm just not packaging DBus on Windows at all, so I need a way to start an appliction without DBus. KDevelop, for instance, use QSingleApplication to ensure only one process is running. | |