Differential D4493

[KCModuleQML] Pass the window as context for paletteChanged
ClosedPublic
Actions

Authored by broulik on Feb 8 2017, 9:39 AM.

Details

Reviewers
mart
dfaure
graesslin
Group Reviewers
Plasma
Commits
R295:3dd7345841be: [KCModuleQML] Pass the window as context for paletteChanged
Summary

This disconnects the connection when the window goes away otherwise it might crash.

Test Plan

Fixes kwin effects kcm crashing in System Settings with D4492 when I change my color scheme where that signal is actually emitted.
The effects KCM doesn't really update its colors but I think that is because the kwin effects kcm doesn't use SystemPalette but takes care of the colors manually

Diff Detail

Repository
R295 KCMUtils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 11043.Feb 8 2017, 9:39 AM
broulik retitled this revision from to [KCModuleQML] Pass the window as context for paletteChanged.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, graesslin, dfaure.
broulik set the repository for this revision to R295 KCMUtils.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 8 2017, 9:39 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Feb 8 2017, 9:39 AM
mart accepted this revision.Feb 8 2017, 9:40 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Feb 8 2017, 9:40 AM
Closed by commit R295:3dd7345841be: [KCModuleQML] Pass the window as context for paletteChanged (authored by broulik). · Explain WhyFeb 8 2017, 11:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcmoduleqml.cpp (2 lines)

Diff 11054

View Options

src/kcmoduleqml.cpp

Loading...