Differential D4487

Extending viewport update area when updating or clearing the a selection rectangle
ClosedPublic
Actions

Authored by mollicaw on Feb 7 2017, 9:09 PM.

Details

Reviewers
aacid
Group Reviewers
Okular
Commits
R223:6f3970dbe48f: Extend viewport update area when updating or clearing the a selection rectangle
Summary

Extending the viewport update area of the selection rectangle when dragging the mouse while in selection mode or when canceling the selection ensures that no artifacts remain on-screen in either case.

BUG: 266537

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mollicaw updated this revision to Diff 11030.Feb 7 2017, 9:09 PM
mollicaw retitled this revision from to Extending viewport update area when updating or clearing the a selection rectangle.
mollicaw updated this object.
mollicaw edited the test plan for this revision. (Show Details)
mollicaw added a reviewer: Okular.
mollicaw set the repository for this revision to R223 Okular.
mollicaw added a project: Okular.
mollicaw updated this object.Feb 7 2017, 9:14 PM
mollicaw added a reviewer: aacid.
mollicaw updated this object.
mollicaw updated this object.Feb 7 2017, 9:18 PM
mollicaw updated this object.Feb 7 2017, 9:39 PM
mollicaw changed the visibility from "All Users" to "Public (No Login Required)".Feb 8 2017, 4:13 PM
aacid edited edge metadata.Feb 8 2017, 7:26 PM

Any reason of why this is needed?

aacid added a comment.Feb 8 2017, 9:35 PM

Why change -1, 1 to -2, 2 and not -20, 20 was my question, i should have been clearer.

mollicaw added a comment.Feb 8 2017, 9:40 PM

From the tests I've done those were the minimum values that fixed the bug.

Closed by commit R223:6f3970dbe48f: Extend viewport update area when updating or clearing the a selection rectangle (authored by mollicaw, committed by aacid). · Explain WhyFeb 8 2017, 10:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mui/pageview.cpp (4 lines)

Diff 11087

View Options

ui/pageview.cpp

Loading...