[Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml
ClosedPublic

Authored by broulik on Feb 7 2017, 9:37 AM.

Details

Summary

QtScript is deprecated and at least in this place it's a straight-forward port.
The Qalculate code path also doesn't need it, so remove it from CMake there.

Test Plan

Used the non-Qalculate code path and typed in some calculations and it seemed to behave exactly like the old one (e.g. yielding "Infinity" for some huge results etc…)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10994.Feb 7 2017, 9:37 AM
broulik retitled this revision from to [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 7 2017, 9:37 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Feb 7 2017, 9:50 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Feb 7 2017, 9:50 AM
This revision was automatically updated to reflect the committed changes.