Differential D4465

Fix i18n extraction in Kickoff Buttons
ClosedPublic
Actions

Authored by davidedmundson on Feb 6 2017, 4:42 PM.

Details

Reviewers
apol
broulik
Group Reviewers
Plasma
Commits
R119:f8a9c37373bb: Fix i18n extraction in Kickoff Buttons
Summary

The current code returns a string containing an array of properties.
This breaks i18n extraction as i18n() inside another string won't work.

This patch returns properties as an object so that i18n translation
works.

The config is also changed so that extraction works properly.

BUG: 375880

Test Plan

Kickoff loads as before
No i18n is nested in a string

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10975.Feb 6 2017, 4:42 PM
davidedmundson retitled this revision from to Fix i18n extraction in Kickoff Buttons.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 6 2017, 4:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Feb 6 2017, 5:04 PM
apol added a reviewer: apol.
This revision is now accepted and ready to land.Feb 6 2017, 5:04 PM
broulik accepted this revision.Feb 6 2017, 5:06 PM
broulik added a reviewer: broulik.
broulik added a subscriber: broulik.
broulik added inline comments.
applets/kickoff/package/contents/ui/FullRepresentation.qml
581

Remove

Closed by commit R119:f8a9c37373bb: Fix i18n extraction in Kickoff Buttons (authored by davidedmundson). · Explain WhyFeb 6 2017, 5:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10976

View Options

applets/kickoff/package/contents/ui/ConfigButtons.qml

Loading...
View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...