Differential D4463

Konqueror can no longer be selected as default file manager
ClosedPublic
Actions

Authored by marten on Feb 6 2017, 4:30 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R226:c27a79e2dbab: Restore the ability to select Konqueror as the default file manager
Summary

Konqueror was originally able to be selected as the default file manager by using kcmshell5 componentchooser ("Default Applications"). Now it does not appear in the list of file manager applications.

This appears to be a result of commit 456dec00 of 26 Sep 2016 ("More cleanup of the "profile" concept") removing kfmclient_dir.desktop and no longer installing it. It's not clear whether this was intentional, but this change restores that file and therefore the ability to select Konqueror as a file manager.

Test Plan

Built konqueror with this change, checked that it can be selected as the default file manager and that it is used correctly for that.

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marten updated this revision to Diff 10973.Feb 6 2017, 4:30 PM
marten retitled this revision from to Konqueror can no longer be selected as default file manager.
marten updated this object.
marten edited the test plan for this revision. (Show Details)
marten added reviewers: Frameworks, dfaure.
marten set the repository for this revision to R226 Konqueror.
dfaure accepted this revision.Feb 6 2017, 4:54 PM
dfaure edited edge metadata.
dfaure added inline comments.
kfmclient_dir.desktop
10

Please make it 9, Dolphin has 10 as well, and Dolphin should be the default file manager.

Gwenview has 8, so the comment would still be respected.

While at it, adjust the comment to "less than Dolphin and more than Gwenview" :-)

This revision is now accepted and ready to land.Feb 6 2017, 4:54 PM
Closed by commit R226:c27a79e2dbab: Restore the ability to select Konqueror as the default file manager (authored by marten). · Explain WhyFeb 6 2017, 5:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
AMkfmclient_dir.desktop (103 lines)

Diff 10978

View Options

CMakeLists.txt

Loading...
View Options

kfmclient_dir.desktop

Loading...