[AppMenu Applet] Map from scene after mapping from global
ClosedPublic
Actions

Authored by broulik on Feb 6 2017, 9:40 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

childAt expects coordinates relative to the item, so we need to mapFromScene before we do that.

BUG: 375535
FIXED-IN: 5.9.1

Test Plan

I added a panel spacer left of my global menu applet and now the correct menu opens on hover. Previously, it was offset by the spacer width.

Also verified that it doesn't break if the panel itself is moved to the right.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [AppMenu Applet] Map from scene after mapping from global.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added a reviewer: Plasma.

broulik set the repository for this revision to R120 Plasma Workspace.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

This revision is now accepted and ready to land.Feb 6 2017, 9:42 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/appmenu/lib/appmenuapplet.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10955			Feb 6 2017, 9:37 AM	★	★
Diff 2	10956	c85fe82	R120:10246712ae307ae9fb9cbaefbecc06e9a2c60cf5	Feb 6 2017, 10:15 AM	★	★