Differential D4401

Pressing Enter should open submenus in Kicker
ClosedPublic
Actions

Authored by davidedmundson on Feb 1 2017, 11:44 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:5e7cbdd445f6: Pressing Enter should open submenus in Kicker
Summary

BUG: 375756

Test Plan

Pressed enter on an item with children. Menu appeared
Pressed enter on an application. It launched as before

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10833.Feb 1 2017, 11:44 PM
davidedmundson retitled this revision from to Pressing Enter should open submenus in Kicker.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 1 2017, 11:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cfeck added a subscriber: cfeck.Feb 2 2017, 12:11 AM

You won't believe how often I have stumbled upon this, so +1

Since you now cannot focus the search field on Enter (after you already used Up/Down), I suggest to focus it on Tab, but without actually inserting a Tab character.

cfeck added inline comments.Feb 2 2017, 12:12 AM
applets/kicker/package/contents/ui/MenuRepresentation.qml
404 ↗(On Diff #10833)

Dave?

davidedmundson updated this revision to Diff 10835.Feb 2 2017, 12:23 AM

Remove enthusiastic debug
Added support for tab key focussing the text box

mart added a subscriber: mart.Feb 3 2017, 10:34 AM

+1
I was windering if even space would make sense for this, tough is better is used for the input field

hein added a subscriber: hein.Feb 4 2017, 3:56 AM

I'll review on Monday, I have a weird gut feeling about this (without looking at the diff) so I want to double-check, sorry :)

hein accepted this revision.Feb 7 2017, 11:06 AM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Feb 7 2017, 11:06 AM
Closed by commit R119:5e7cbdd445f6: Pressing Enter should open submenus in Kicker (authored by davidedmundson). · Explain WhyFeb 16 2017, 10:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11398

View Options

applets/kicker/package/contents/ui/ItemListView.qml

Loading...