Fix potential crash in KCmFontInst on invalid index
ClosedPublic

Authored by davidedmundson on Feb 1 2017, 1:43 PM.

Details

Summary

If !index.isValid() grp remains null and any use of it will crash.

There is a check for that, but then there's code relying on grp being
valid both before and after that check.

Test Plan

Compiles

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Fix potential crash in KCmFontInst on invalid index.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 1 2017, 1:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 22 2017, 4:37 PM
This revision is now accepted and ready to land.Feb 22 2017, 4:37 PM
This revision was automatically updated to reflect the committed changes.