Ensure the layoutChanged DBus signal gets emitted when changing layouts through DBus
ClosedPublic

Authored by graesslin on Feb 1 2017, 6:08 AM.

Details

Summary

Unfortunately Xkb does not emit a signal when the keyboard layout
changes. Due to that we need to manually check in KeyboardLayout after
each action which could change the layout whether the layout changed.

This was not yet done for the case when the layout got changed through
the DBus interface. Resulting in the DBus signal not emitted.

This change addresses the issue by invoking the check for change after
changing the keyboard layout.

Test Plan

Added test case

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 10799.Feb 1 2017, 6:08 AM
graesslin retitled this revision from to Ensure the layoutChanged DBus signal gets emitted when changing layouts through DBus.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptFeb 1 2017, 6:08 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Feb 6 2017, 6:33 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Feb 6 2017, 6:33 PM
This revision was automatically updated to reflect the committed changes.