Differential D4385

Enable the Debug level when enabling "all debug"
ClosedPublic
Actions

Authored by ltoscano on Feb 1 2017, 12:41 AM.

Details

Reviewers
mlaurent
Commits
R355:74568d264227: Enable the Debug level when enabling "all debug"
Summary

The wording on the label suggests that the effect will be a real
full debug, not just the "Info" level.

Test Plan

When "Enable All Debug" is selected, the level of all categories is set
to "Debug" instead of "Info".

Diff Detail

Repository
R355 KDebugSettings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano updated this revision to Diff 10794.Feb 1 2017, 12:41 AM
ltoscano retitled this revision from to Enable the Debug level when enabling "all debug".
ltoscano updated this object.
ltoscano edited the test plan for this revision. (Show Details)
ltoscano added a reviewer: mlaurent.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptFeb 1 2017, 12:41 AM
mlaurent edited edge metadata.Feb 1 2017, 5:53 AM

Good catch.
Are you verify that all autotests are ok ?

Regards

ltoscano added a comment.Feb 1 2017, 8:20 AM

The autotests pass. (14 tests right now, including appstreamtest which runs only when there is a change, but that's another story).

mlaurent accepted this revision.Feb 2 2017, 5:42 AM
mlaurent edited edge metadata.

Ship it.
thanks

This revision is now accepted and ready to land.Feb 2 2017, 5:42 AM
Closed by commit R355:74568d264227: Enable the Debug level when enabling "all debug" (authored by ltoscano). · Explain WhyFeb 2 2017, 8:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10839

View Options

src/kdeapplicationtreelistwidget.cpp

Loading...