Differential D4381

openxchange: display full error message
ClosedPublic
Actions

Authored by scarpino on Jan 31 2017, 11:19 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R44:b00e6e99732b: openxchange: display full error message
R44:0412d8322dd0: openxchange: display full error message
R44:75c00380d883: openxchange: display full error message
R44:594467e9c4fc: openxchange: display full error message
Summary

The previous code splits the error text on the first slash, but newer
xchange servers could return error messages with slashes in the text.

CCBUG: 333408

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
scarpino updated this revision to Diff 10789.Jan 31 2017, 11:19 PM
scarpino retitled this revision from to openxchange: display full error message.
scarpino updated this object.
scarpino edited the test plan for this revision. (Show Details)
scarpino added a reviewer: KDE PIM.
Restricted Application added a project: KDE PIM. · View Herald TranscriptJan 31 2017, 11:19 PM
scarpino updated this revision to Diff 10791.Jan 31 2017, 11:22 PM

No need to rename error variable

mlaurent accepted this revision.Feb 1 2017, 5:49 AM
mlaurent added a reviewer: mlaurent.
mlaurent added a subscriber: mlaurent.

I am not the openxchange dev but it's more logical to use json parsing here.

Ship it please.

This revision is now accepted and ready to land.Feb 1 2017, 5:49 AM
Closed by commit R44:594467e9c4fc: openxchange: display full error message (authored by scarpino). · Explain WhyFeb 1 2017, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10828

View Options

resources/openxchange/oxa/connectiontestjob.cpp

Loading...