Set a longer wallpaper transition time

Authored by davidedmundson on Jan 31 2017, 3:03 PM.



Whilst using units is generally good, the wallpaper transition time is
way too short. It's a different type of animation to the others,
especially in a slideshow, where the transition is an important part of
the behaviour.

This patch loads it from a hidden configuration option with a duration
of 1000ms, if and only if animations are enabled.

Value determined through brief trial and error.

BUG: 365979

Test Plan

Opened wallpaper. Clicked next.
Also changed static wallpaper manually, transition looked fine

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Set a longer wallpaper transition time.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2017, 3:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Mar 2 2017, 8:30 PM
broulik added a subscriber: broulik.

Just noticed I hadn't set my sails for adventure when I first saw this. Let's go with this I'd say.


There's two spaces


This works in JS but I'd prefer it to be more explicit

units.longDuration > 0 ? wallpaper.configuration.TransitionAnimationDuration : 0

(says the one who prefers foo || bar over foo ? foo : bar :D)

This revision is now accepted and ready to land.Mar 2 2017, 8:30 PM
This revision was automatically updated to reflect the committed changes.