Don't set gnu style parameter with Clang and MSVC
Needs ReviewPublic

Authored by vonreth on Jan 31 2017, 11:46 AM.

Details

Reviewers
dfaure
bcooksley
alexmerry
Group Reviewers
Windows
Summary

Setting the gnu style compiler flags with clang-cl results in a
huge bunch of unknown argument warnings.

The patch just tests for Clang AND NOT MSVC, while we might wan't
a more fine gained test for clang-cl, as in theory it could be
possible to use a plain clang++ with msvc.

Diff Detail

Repository
R240 Extra CMake Modules
Branch
arcpatch-D4363
Lint
No Linters Available
Unit
No Unit Test Coverage
vonreth updated this revision to Diff 10756.Jan 31 2017, 11:46 AM
vonreth retitled this revision from to Don't set gnu style parameter with Clang and MSVC.
vonreth updated this object.
vonreth edited the test plan for this revision. (Show Details)
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJan 31 2017, 11:46 AM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
dfaure edited edge metadata.Jan 31 2017, 10:23 PM

I'm no expert but this seems ok, no objection from me.

vonreth updated this revision to Diff 10822.Feb 1 2017, 1:48 PM
vonreth edited edge metadata.

Small fix

Is this still relevant? If yes, from the diff, looks ok for me.

Restricted Application edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. · View Herald TranscriptOct 9 2019, 6:14 PM