Differential D4356

Fix UI string: remove placeholders for arguments
ClosedPublic
Actions

Authored by ltoscano on Jan 31 2017, 12:50 AM.

Details

Reviewers
chehrlic
lueck
Commits
R220:6902f58d4bde: Fix UI string: remove placeholders for arguments
Summary

%1, %2,... are interpreted as placeholders for arguments leading to
an I18n_ARGUMENT_MISSING error in the visible string. Rewrite them
as more generic placeholder which are not replaced, as it was done
for other strings in the same file.

Test Plan

When accessing the configuration of 'Diff & Merge', "What's this"
on "External diff display", there is no more I18n_ARGUMENT_MISSING
error.

Diff Detail

Repository
R220 Subversion Client (KDE SVN)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano updated this revision to Diff 10748.Jan 31 2017, 12:50 AM
ltoscano retitled this revision from to Fix UI string: remove placeholders for arguments.
ltoscano updated this object.
ltoscano edited the test plan for this revision. (Show Details)
ltoscano added a reviewer: chehrlic.
ltoscano added a subscriber: Localization.
ltoscano added projects: Localization, Subversion Client (KDE SVN).Jan 31 2017, 12:51 AM

I would have pushed this directly to master, but I was not sure if I could push it to 2.0 as well, because it breaks one string. Hence the review.

lueck accepted this revision.Jan 31 2017, 8:24 AM
lueck added a reviewer: lueck.
lueck added a subscriber: lueck.

with the patch the I18n_ARGUMENT_MISSING error

src/settings/diffmergesettings.ui
186–188

Probably the string could be improved:
If using the first or second form, svn itself will generate the diff. %f will be replaced with a temporary filename. If %f is not given,
the diff-display should able to read data from stdin.

190

Probably the string could be improved:
When %1 and %2 are given, kdesvn lets this display make the diff. For that it makes a temporary export or get (if needed)
and fill out the parameters with the right value. %1 will be filled with the content of start-revision, %2 with the endrevision. On large recursive diffs this may get real slow.

This revision is now accepted and ready to land.Jan 31 2017, 8:24 AM
ltoscano updated this revision to Diff 10796.EditedFeb 1 2017, 1:00 AM
ltoscano edited edge metadata.

Add the fixes suggested by Burkhard, and others fixes.

ltoscano marked 2 inline comments as done.Feb 1 2017, 1:01 AM

Then it's definitely targeted to master, not 2.0.

chehrlic accepted this revision.Feb 26 2017, 7:30 PM
Closed by commit R220:6902f58d4bde: Fix UI string: remove placeholders for arguments (authored by ltoscano). · Explain WhyFeb 26 2017, 7:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/settings/diffmergesettings.ui (10 lines)

Diff 11861

View Options

src/settings/diffmergesettings.ui

Loading...