Drop legacy fixup rule for VirtualBox.
ClosedPublic

Authored by hein on Jan 30 2017, 11:40 AM.

Details

Summary

Versions of VirtualBox packaged on Neon and Fedora now have
a proper WM_CLASS:
Fedora: WM_CLASS(STRING) = "VirtualBox", "VirtualBox"
Neon: WM_CLASS(STRING) = "Qt-subapplication", "VirtualBox"

And install a matching virtualbox.desktop.

We can therefore drop this rule.

BUG:350468

Side note: The rule should actually still have worked, but
for some reason KServiceTypeTrader refuses to match a .desktop
with 'Exec=VirtualBox %U' when we query for 'VirtualBox', as
extracted from cmdline. I'm talking to dfaure about it.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein retitled this revision from to Drop legacy fixup rule for VirtualBox..Jan 30 2017, 11:40 AM
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added reviewers: Plasma, broulik.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 30 2017, 11:40 AM
hein updated this revision to Diff 10709.Jan 30 2017, 12:03 PM

Fix messed-up patch.

davidedmundson accepted this revision.Jan 30 2017, 12:06 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 30 2017, 12:06 PM
This revision was automatically updated to reflect the committed changes.