Differential D4325

Make output filtering more robust to app invalid columns
ClosedPublic
Actions

Authored by volden on Jan 28 2017, 6:02 PM.

Details

Reviewers
mwolff
kdevelop-devel
Commits
R33:9e17bcd4c2b0: Make output filtering more robust to app invalid columns Summary: In some cases…
R32:721d7b96707d: Make output filtering more robust to app invalid columns Summary: In some cases…
R32:9e17bcd4c2b0: Make output filtering more robust to app invalid columns Summary: In some cases…
Summary

Make output filtering more robust to app invalid columnsIn some cases

Test Plan

Added a unit test to verify.

Manual testing done

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
volden updated this revision to Diff 10660.Jan 28 2017, 6:02 PM
volden retitled this revision from to Make output filtering more robust to app invalid columns.
volden updated this object.
volden edited the test plan for this revision. (Show Details)
volden added a reviewer: kdevelop-devel.
volden set the repository for this revision to R33 KDevPlatform.
volden updated this revision to Diff 10661.Jan 28 2017, 6:28 PM
volden removed R33 KDevPlatform as the repository for this revision.
volden updated this revision to Diff 10662.Jan 28 2017, 6:31 PM
volden set the repository for this revision to R33 KDevPlatform.
mwolff requested changes to this revision.Jan 29 2017, 7:43 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

minor style nitpick, otherwise lgtm - thanks!

outputview/outputformats.cpp
52

style: spaces after if, always use braces

overall, I'd rewrite this as:

return columnGroup < 0 ? 0 : std::max(match.captured(columnGroup).toInt() - 1, 0);
This revision now requires changes to proceed.Jan 29 2017, 7:43 PM
volden updated this revision to Diff 10706.Jan 30 2017, 10:46 AM
volden edited edge metadata.
volden marked an inline comment as done.
volden updated this revision to Diff 10710.Jan 30 2017, 12:10 PM
volden edited edge metadata.
mwolff accepted this revision.Jan 30 2017, 1:47 PM
mwolff edited edge metadata.

nice, thanks a lot

This revision is now accepted and ready to land.Jan 30 2017, 1:47 PM
Closed by commit R33:9e17bcd4c2b0: Make output filtering more robust to app invalid columns Summary: In some cases… (authored by volden). · Explain WhyJan 30 2017, 5:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10662

View Options

outputview/outputformats.h

Loading...
View Options

outputview/outputformats.cpp

Loading...
View Options

outputview/tests/test_filteringstrategy.cpp

Loading...