Make output filtering more robust to app invalid columnsIn some cases
Details
Details
- Reviewers
mwolff kdevelop-devel - Commits
- R33:9e17bcd4c2b0: Make output filtering more robust to app invalid columns Summary: In some cases…
R32:721d7b96707d: Make output filtering more robust to app invalid columns Summary: In some cases…
R32:9e17bcd4c2b0: Make output filtering more robust to app invalid columns Summary: In some cases…
Added a unit test to verify.
Manual testing done
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
minor style nitpick, otherwise lgtm - thanks!
outputview/outputformats.cpp | ||
---|---|---|
52–54 | style: spaces after if, always use braces overall, I'd rewrite this as: return columnGroup < 0 ? 0 : std::max(match.captured(columnGroup).toInt() - 1, 0); |