Adjust KeyboardLayout to non-kded DBus service
ClosedPublic

Authored by graesslin on Jan 28 2017, 1:35 PM.

Details

Summary

The keyboard layout kded module does also register a dedicated DBus
service and a dedicated object. By using the newer service name we
can also provide the same on Wayland where there is no kded module
for keyboard.

Test Plan

Not yet tested as I'm on Wayland

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 10654.Jan 28 2017, 1:35 PM
graesslin retitled this revision from to Adjust KeyboardLayout to non-kded DBus service.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a project: Plasma on Wayland. · View Herald TranscriptJan 28 2017, 1:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Jan 30 2017, 10:04 AM

is there anything out there still depending from the old name?

I don't know, though they still work with the old name. Just not on Wayland.

According to lxr.kde.org this was the only usage of /modules/keyboard and searching for org.kde.KeyboardLayouts shows no usage combined with org.kde.kded5. So I am quite certain that this here was the only "incorrect" usage.

davidedmundson accepted this revision.Feb 2 2017, 7:27 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Feb 2 2017, 7:27 PM
This revision was automatically updated to reflect the committed changes.