Split Keyboard Repeat handling into a dedicated InputEventSpy
ClosedPublic

Authored by graesslin on Jan 27 2017, 6:09 AM.

Details

Summary

So far the keyboard repeat handling was triggered directly from
KeyboardInputRedirection::processKey. With the introduction of
InputEventSpies it is no longer required to be done like that, we can
split it out into a dedicated spy.

This means that processKey only has to care about processing the key
and allows us to better extend in future. So far keyboard repeat is
only functional for libinput based platforms. But it should also be
possible to use it in nested setups. By splitting it out we can
prepare for that.

Test Plan

Auto-test using repeat still passes

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 10609.Jan 27 2017, 6:09 AM
graesslin retitled this revision from to Split Keyboard Repeat handling into a dedicated InputEventSpy.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJan 27 2017, 6:09 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 27 2017, 11:20 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 27 2017, 11:20 AM
This revision was automatically updated to reflect the committed changes.