[Color Picker] Add contrast frame around colors in popup
ClosedPublic

Authored by broulik on Jan 26 2017, 3:25 PM.

Details

Summary

This adds a frame around the color sections, makes it look a lot nicer and improves contrast.

Since here the frame takes only a minor portion of surface area compared to the circle in a panel, I opted not to base it on luminosity, also for consistency's sake when there's 9 different colors in one view.

Test Plan

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10596.Jan 26 2017, 3:25 PM
broulik retitled this revision from to [Color Picker] Add contrast frame around colors in popup.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 26 2017, 3:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 26 2017, 3:57 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 26 2017, 3:57 PM
This revision was automatically updated to reflect the committed changes.

Look good to me +1