Differential D4282

Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate
ClosedPublic
Actions

Authored by drosca on Jan 25 2017, 5:20 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:d2c7435b1bc1: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate
Test Plan

Expand applet in systray -> open config -> applet popup gets closed

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 10558.Jan 25 2017, 5:20 PM
drosca retitled this revision from to Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 25 2017, 5:20 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
hein added a subscriber: hein.Jan 25 2017, 6:01 PM

This is what I suggested in IRC, but Kai had some concerns that it wasn't always desired.

broulik added a comment.Jan 25 2017, 6:06 PM

I was under the impression that opening a plasma config dialog would keep the popup opened but then I found that it doesn't (at least not the default popup impl) after I already submitted the patch.

davidedmundson accepted this revision.Jan 26 2017, 1:20 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 26 2017, 1:20 PM
Closed by commit R242:d2c7435b1bc1: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate (authored by drosca). · Explain WhyJan 26 2017, 2:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasmaquick/dialog.cpp (3 lines)

Diff 10590

View Options

src/plasmaquick/dialog.cpp

Loading...