[Task Manager] Hide group dialog when opening applets settings
ClosedPublic

Authored by broulik on Jan 25 2017, 4:27 PM.

Details

Summary

When moving focus from one Plasma window to another (e.g. in this case opening the applet config dialog), Plasma Dialog stays open even with hideOnWindowDeactivate.

Since changing task manager settings might affect grouping and triggers unintentional behavior when the model is used in a GroupDialog without grouping / fildering, just hide the popup in this case.

Test Plan

This also makes it consistent with Plasma which explicitly collapses applets prior to showing their config interface. System tray does the same.

Opened group dialog, clicked "configure task manager", group dialog closed.

Before that I could open the group dialog, then disable grouping in popups and ended up with a huge dialog of all windows that I couldn't get rid of without restarting plasma.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik retitled this revision from to [Task Manager] Hide group dialog when opening applets settings.Jan 25 2017, 4:27 PM
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 25 2017, 4:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Jan 25 2017, 4:36 PM

Should be in 5.8 and up.

This revision is now accepted and ready to land.Jan 25 2017, 4:36 PM
This revision was automatically updated to reflect the committed changes.
drosca added a subscriber: drosca.Jan 25 2017, 5:20 PM

Shouldn't this be fixed in plasma-framework instead? D4282