| mwolff |
The documentation on AbstractType says subclasses must have a BaseType typedef. However, very few types actually had it, and nothing uses it anymore (apparently only the oldcpp code used it in the past).
So I'm removing the remaining BaseType typedefs, and adjusting the doxygen comment that says you need it.
If approved, I'll send patches for other repos too (kdevelop has 1 remaining BaseType and kdev-python has 3).
Tested compilation of KDevPlatform, KDevelop, and KDev-Python (master branch for all).
| No Linters Available |
| No Unit Test Coverage |
this could be useful though for generic code, potentially - no?
anyhow, if it's really unused, feel free to remove it...
If you think BaseType is useful and should be kept, that's another option. But then we should add it to all the types that don't have it!
nah, if it's not used, adding it makes no sense. anyhow, I'm undecided on this. if we need it in the future we can add it, right? so go for it
@mwolff I screwed up with the commit message and this review didn't get automatically closed. I also can't close it manually. Maybe you need to "formally" mark it as approved in Phabricator?