Talking about "Application" is inconsistent with rest of UI,
like warnings talking about "project name"
Also can be all kind of projects be created here, e.g. plugins,
thus "project name" is more neutral.
Details
Details
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
+1
What branch are you targeting? This doesn't break API/ABI but does change strings. Is 5.1 in string freeze?
Comment Actions
IIRC on another patch it was said that 5.1 is in string freeze already. So was also only targetting master for now.
Comment Actions
The logical extension of this would be to rename the entire plugin, and many related methods/classes/files - if appName() is misleading/wrong, then so is ApplicationInfo::name and of course AppWizard. ;-)
(That might be a bit excessive.)
Comment Actions
Thanks all for review.
Agree that it will be consequent to rename also more things from App->Template.
But for now stopped at this stage, as I have at least 2 WIP patches which would be affected that, so any renaming will complicate things for me.
So more renaming on my agenda, but only after at least those 2 patches are done and in :)