Differential D4224

[Color Picker] Add border around color if contrast to surrounding view is too little
ClosedPublic
Actions

Authored by broulik on Jan 20 2017, 3:17 PM.

Details

Reviewers
mart
Commits
R114:ef3fd95a3257: [Color Picker] Add border around color if contrast to surrounding view is too…
Summary

When picking a light color on a light panel, it might not be obvious that the color is shown there.
Add a border around the picked color if contrast is too little.

Test Plan

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10389.Jan 20 2017, 3:17 PM
broulik retitled this revision from to [Color Picker] Add border around color if contrast to surrounding view is too little.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 20 2017, 3:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a comment.Jan 20 2017, 3:20 PM

Just noticed I could have probably used

QColor::getHsl
mart accepted this revision.Jan 25 2017, 11:37 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 25 2017, 11:37 AM
Closed by commit R114:ef3fd95a3257: [Color Picker] Add border around color if contrast to surrounding view is too… (authored by broulik). · Explain WhyJan 26 2017, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10595

View Options

applets/colorpicker/package/contents/ui/main.qml

Loading...