Remove pointless QObject inheritance in model item
ClosedPublic

Authored by davidedmundson on Jan 20 2017, 3:13 AM.

Details

Summary

We don't emit anything or use properties or anything else that requires
MOC. We want to keep model items light.

The emitDataChanged in setRunning still works because that's part of
QStandardItem. Memory management is the same beacuse the
QStandardItemModel takes ownership in appendRow().

Test Plan

Opened widget explorer.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Remove pointless QObject inheritance in model item.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 20 2017, 3:13 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 23 2017, 5:01 PM
mart added a reviewer: mart.
mart added a subscriber: mart.

simplification++

This revision is now accepted and ready to land.Jan 23 2017, 5:01 PM
This revision was automatically updated to reflect the committed changes.