[Task Manager] Remove arbitrary sizes from tooltip
AbandonedPublic

Authored by broulik on Jan 17 2017, 2:35 PM.

Details

Reviewers
romangg
hein
Group Reviewers
Plasma: Design
Plasma
Summary

Use a level 3 Heading for the title (same as default tooltip elsewhere in Plasma), use default font for the middle one and smallFont for bottom one.

Removes the spacing on the Column and instead unsets the additional margins the Labels provide to still result in a tight layout.

Test Plan

(btw can we make the window title label wrap or will that screw things up?)


(note this is with 125% scaling so it might not be representative)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 10281.Jan 17 2017, 2:35 PM
broulik retitled this revision from to [Task Manager] Remove arbitrary sizes from tooltip.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design, romangg.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2017, 2:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein added a subscriber: hein.Jan 17 2017, 2:36 PM

Screenshot?

broulik updated this revision to Diff 10282.Jan 17 2017, 2:36 PM
broulik removed a subscriber: hein.

Use Heading opacity instead of forcing it to be 1

broulik edited the test plan for this revision. (Show Details)Jan 17 2017, 2:41 PM
hein accepted this revision.Jan 17 2017, 2:43 PM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Jan 17 2017, 2:43 PM
romangg edited edge metadata.Jan 17 2017, 2:46 PM

Before you commit give me a few minutes time please.

romangg added a subscriber: Fuchs.Jan 17 2017, 3:17 PM

The gap between the app name and the top of the tooltip is increased. Is it possible to reduce it? Otherwise the tooltip in total gets bigger again and the close button to me doesn't look aligned anymore with the top text line.

Imo the app name should have higher opacity than the other lines. Either set it to 1 again (is it necessary to have headings at 0.8?) or decrease opacity of window title and subtext further.

Since we talked on IRC about it and that was the initial reason: @Fuchs will still not like it this way, since the size of the text itself stays the same (but imo it shouldn't increase anyway to not increase the size of the tooltips again).

In general I am for using headings over my makeshift "magic" numbers, but only if it doesn't change the design (in maybe subtle ways). Otherwise I want some people from the VDG to say what they think about it.

mart added a subscriber: mart.Jan 18 2017, 10:11 AM
mart added inline comments.
applets/taskmanager/package/contents/ui/ToolTipInstance.qml
92

try to restore this spacing, maybe is the reson the tooltip is still a bit larger

broulik added inline comments.Jan 18 2017, 4:17 PM
applets/taskmanager/package/contents/ui/ToolTipInstance.qml
92

I don't understand. Column (in contrast to ColumnLayout) has a default spacing of 0

OK i see it's doubled. So one of those must accepted, current situation is completely frustrating.

This can be abandoned now, right?

broulik abandoned this revision.Feb 10 2017, 6:07 PM