Move X11 specific KGlobalAccel handling into the x11-standalone platform
ClosedPublic
Actions

Authored by graesslin on Jan 17 2017, 6:15 AM.

Details

Reviewers

Group Reviewers

Plasma
KWin

Commits

R108:2904d4a0be45: Move X11 specific KGlobalAccel handling into the x11-standalone platform

Summary

InputRedirection has a workaround to add a connect on a QAction which
is used for a global shortcut. This is specific to the X11 platform as
the xtime needs to be updated.

This change adds a new virtual method to the Platform and moves the
implementation into the X11 standalone platform. Thus it does no longer
gets called on Wayland.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 10269.Jan 17 2017, 6:15 AM

graesslin retitled this revision from to Move X11 specific KGlobalAccel handling into the x11-standalone platform.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma.

Restricted Application added a project: KWin. · View Herald TranscriptJan 17 2017, 6:15 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

romangg accepted this revision.Jan 17 2017, 9:39 AM

romangg added a reviewer: romangg.

This revision is now accepted and ready to land.Jan 17 2017, 9:39 AM

Closed by commit R108:2904d4a0be45: Move X11 specific KGlobalAccel handling into the x11-standalone platform (authored by graesslin). · Explain WhyJan 17 2017, 4:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/test_screen_edges.cpp (5 lines)
M			autotests/test_virtual_desktops.cpp (5 lines)
M			input.h (1 line)
M			input.cpp (14 lines)
M			platform.h (18 lines)
M			platform.cpp (5 lines)
M			plugins/platforms/x11/standalone/x11_platform.h (2 lines)
M			plugins/platforms/x11/standalone/x11_platform.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10269	5baf75d		Jan 17 2017, 6:15 AM	★	★
Diff 2	10287	516eb82	R108:2904d4a0be4509235d1b9d91b342dbb611f0e8a4	Jan 17 2017, 4:01 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0639a114351b	43b345c12f92	5baf75d11eda	Martin Gräßlin	Move X11 specific KGlobalAccel handling into the x11-standalone platform (Show More…)	Jan 17 2017, 6:12 AM