diff --git a/applets/appmenu/plugin/appmenumodel.cpp b/applets/appmenu/plugin/appmenumodel.cpp --- a/applets/appmenu/plugin/appmenumodel.cpp +++ b/applets/appmenu/plugin/appmenumodel.cpp @@ -225,12 +225,12 @@ m_importer->deleteLater(); } - m_importer = new KDBusMenuImporter(serviceName, menuObjectPath, this); + m_importer = new KDBusMenuImporter(serviceName, menuObjectPath, this); QMetaObject::invokeMethod(m_importer, "updateMenu", Qt::QueuedConnection); - connect(m_importer.data(), &DBusMenuImporter::menuUpdated, this, [=] { + connect(m_importer.data(), &DBusMenuImporter::menuUpdated, this, [=](QMenu *menu) { m_menu = m_importer->menu(); - if (m_menu.isNull()) { + if (m_menu.isNull() || menu != m_menu) { return; } setMenuAvailable(true); diff --git a/appmenu/appmenu.cpp b/appmenu/appmenu.cpp --- a/appmenu/appmenu.cpp +++ b/appmenu/appmenu.cpp @@ -136,9 +136,9 @@ QMetaObject::invokeMethod(importer, "updateMenu", Qt::QueuedConnection); disconnect(importer, 0, this, 0); // ensure we don't popup multiple times in case the menu updates again later - connect(importer, &KDBusMenuImporter::menuUpdated, this, [=] { + connect(importer, &KDBusMenuImporter::menuUpdated, this, [=](QMenu *m) { QMenu *menu = importer->menu(); - if (!menu) { + if (!menu || menu != m) { return; } m_menu = qobject_cast(menu); diff --git a/dataengines/statusnotifieritem/statusnotifieritemsource.cpp b/dataengines/statusnotifieritem/statusnotifieritemsource.cpp --- a/dataengines/statusnotifieritem/statusnotifieritemsource.cpp +++ b/dataengines/statusnotifieritem/statusnotifieritemsource.cpp @@ -368,7 +368,11 @@ qWarning() << "DBusMenu disabled for this application"; } else { m_menuImporter = new PlasmaDBusMenuImporter(m_statusNotifierItemInterface->service(), menuObjectPath, iconLoader(), this); - connect(m_menuImporter, SIGNAL(menuUpdated()), this, SLOT(contextMenuReady())); + connect(m_menuImporter, &PlasmaDBusMenuImporter::menuUpdated, this, [this](QMenu *menu) { + if (menu == m_menuImporter->menu()) { + contextMenuReady(); + } + }); } } } diff --git a/libdbusmenuqt/dbusmenuimporter.h b/libdbusmenuqt/dbusmenuimporter.h --- a/libdbusmenuqt/dbusmenuimporter.h +++ b/libdbusmenuqt/dbusmenuimporter.h @@ -69,7 +69,7 @@ * Emitted after a call to updateMenu(). * @see updateMenu() */ - void menuUpdated(); + void menuUpdated(QMenu *); /** * Emitted when the exporter was asked to activate an action diff --git a/libdbusmenuqt/dbusmenuimporter.cpp b/libdbusmenuqt/dbusmenuimporter.cpp --- a/libdbusmenuqt/dbusmenuimporter.cpp +++ b/libdbusmenuqt/dbusmenuimporter.cpp @@ -375,20 +375,22 @@ int parentId = watcher->property(DBUSMENU_PROPERTY_ID).toInt(); watcher->deleteLater(); + QMenu *menu = d->menuForId(parentId); + QDBusPendingReply reply = *watcher; if (!reply.isValid()) { qWarning() << reply.error().message(); - - emit menuUpdated(); + if (menu) { + emit menuUpdated(menu); + } return; } #ifdef BENCHMARK DMDEBUG << "- items received:" << sChrono.elapsed() << "ms"; #endif DBusMenuLayoutItem rootItem = reply.argumentAt<1>(); - QMenu *menu = d->menuForId(parentId); if (!menu) { qWarning() << "No menu for id" << parentId; return; @@ -443,7 +445,7 @@ } } - emit menuUpdated(); + emit menuUpdated(menu); } void DBusMenuImporter::sendClickedEvent(int id) @@ -477,24 +479,26 @@ int id = watcher->property(DBUSMENU_PROPERTY_ID).toInt(); watcher->deleteLater(); + QMenu *menu = d->menuForId(id); + QDBusPendingReply reply = *watcher; if (reply.isError()) { - menuUpdated(); qWarning() << "Call to AboutToShow() failed:" << reply.error().message(); + if (menu) { + menuUpdated(menu); + } return; } //Note, this isn't used by Qt's QPT - but we get a LayoutChanged emitted before //this returns, which equates to the same thing bool needRefresh = reply.argumentAt<0>(); - QMenu *menu = d->menuForId(id); - DMRETURN_IF_FAIL(menu); if (needRefresh || menu->actions().isEmpty()) { d->m_idsRefreshedByAboutToShow << id; d->refresh(id); - } else { - menuUpdated(); + } else if (menu) { + menuUpdated(menu); } }