Create a new entry in the KCofig to save / restore
the ToolBars of the toolviews
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Create a new entry in the KCofig to save / restore
the ToolBars of the toolviews
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
manual testing
No Linters Available |
No Unit Test Coverage |
sublime/idealcontroller.cpp | ||
---|---|---|
123 ↗ | (On Diff #10141) | add this as signal receiver. |
sublime/idealcontroller.cpp | ||
---|---|---|
126 | Too Much QSettings makes tomaz misbehave. |
sublime/idealcontroller.cpp | ||
---|---|---|
121 ↗ | (On Diff #10141) | spaces after commas, here and below |
121 ↗ | (On Diff #10141) | the windowTitle is a translated string, and it's not guaranteed to be unique, is it? I don't think it's a good idea to use that as an identifier. Can you instead use the dockObjectName (see above)? |
one minor code style nitpick, then it's ready to go
thanks!
sublime/idealcontroller.cpp | ||
---|---|---|
122 ↗ | (On Diff #10141) | please introduce a newline before the this and indent the lambda body connect(toolBar->toggleViewAction(), &QAction::toggled, this, [toolBar, dockObjectName]() { ... }); |