Differential D4107

[Task Manager] Don't show separator between media controls and "Mute"
ClosedPublic
Actions

Authored by broulik on Jan 12 2017, 4:53 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:2b404bd65c58: [Task Manager] Don't show separator between media controls and "Mute"
Summary

While they're technically separate for the user they're semantically related.
After the separator we have a Quit and Raise option for launchers but we cannot have an audio stream for a non-window since we don't know the PID so we can do this here.

Test Plan

No more separator when there are audio controls. Still get if if I don't have them.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10112.Jan 12 2017, 4:53 PM
broulik retitled this revision from to [Task Manager] Don't show separator between media controls and "Mute".
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 12 2017, 4:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Jan 12 2017, 4:59 PM
hein edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jan 12 2017, 4:59 PM
Closed by commit R119:2b404bd65c58: [Task Manager] Don't show separator between media controls and "Mute" (authored by broulik). · Explain WhyJan 13 2017, 1:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10134

View Options

applets/taskmanager/package/contents/ui/ContextMenu.qml

Loading...