Differential D4104

Fix compare for undefined argument in playFeedback()
ClosedPublic
Actions

Authored by drosca on Jan 12 2017, 1:59 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R994:2b87302d9d01: Fix compare for undefined argument in playFeedback()
R115:2b87302d9d01: Fix compare for undefined argument in playFeedback()
Summary

Calling playFeedback(0) would incorrectly play feedback on preferred sink.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 10102.Jan 12 2017, 1:59 PM
drosca retitled this revision from to Fix compare for undefined argument in playFeedback().
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 12 2017, 1:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jan 12 2017, 1:59 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 12 2017, 1:59 PM
Closed by commit R115:2b87302d9d01: Fix compare for undefined argument in playFeedback() (authored by drosca). · Explain WhyJan 24 2017, 12:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplet/contents/ui/main.qml (2 lines)

Diff 10493

View Options

applet/contents/ui/main.qml

Loading...