[libinput] Connection object in main thread for DBus connection
ClosedPublic

Authored by romangg on Jan 11 2017, 11:14 AM.

Details

Summary

The last patch https://phabricator.kde.org/D4027 regarding this topic "solved" the problem by accidentally disabling the DBus connection in total. This patch should restore it and Connection now sends signals form main thread, which solves problems of failed login and error spam.

I had on my laptop the problem of logout not working. But this also happens without this patch, so it's another problem. Martin, could you test your DPMS with it which you described in https://bugs.kde.org/show_bug.cgi?id=374554?

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg updated this revision to Diff 10035.Jan 11 2017, 11:14 AM
romangg retitled this revision from to [libinput] Connection object in main thread for DBus connection.
romangg updated this object.
romangg edited the test plan for this revision. (Show Details)
romangg added a reviewer: KWin.
romangg set the repository for this revision to R108 KWin.
romangg added projects: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel. · View Herald TranscriptJan 11 2017, 11:14 AM

Note, that the Wayland Touchpad KCM won't work without this patch. So it's rather important.

davidedmundson accepted this revision.Jan 11 2017, 5:57 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

For future reference, it's possible to auto generate adaptors from an XML file.

Though that's mostly useful if your signal names match.

This revision is now accepted and ready to land.Jan 11 2017, 5:57 PM

Just tested on my system: looks good, I didn't get a crash when going to DPMS.

This revision was automatically updated to reflect the committed changes.