Details
Details
- Reviewers
apol - Group Reviewers
KDevelop - Commits
- R33:df17740e8ee7: WelcomePage: Show news entries from kdevelop.org
R32:df17740e8ee7: WelcomePage: Show news entries from kdevelop.org
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
This is mostly a RFC.
Things to do:
- Discuss privacy aspects (do we need an opt in, an opt out)?
- Need to implement a cache so we don't poll the kdevelop.org server every time KDevelop is started (polling like once per day should be totally sufficient)
Comment Actions
I doubt it will be a drain to download upon request, especially if it's not shown in the main page...
Comment Actions
Changes:
- Simplify code a bit (no need for printing age actually, we're not a news ticker but just show recent posts)
- Use locale aware functions to convert date to string
Comment Actions
LGTM me now, please review again.
We can probably add a 'disable news' action to the welcome page later, if we want to and in case we get roasted because of the 'calling home' feature ;)