WelcomePage: Show news entries from kdevelop.org
ClosedPublic

Authored by kfunk on Jan 11 2017, 12:37 AM.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk updated this revision to Diff 10014.Jan 11 2017, 12:37 AM
kfunk retitled this revision from to WelcomePage: Show news entries from kdevelop.org.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 11 2017, 12:37 AM
kfunk planned changes to this revision.Jan 11 2017, 12:38 AM

This is mostly a RFC.

Things to do:

  • Discuss privacy aspects (do we need an opt in, an opt out)?
  • Need to implement a cache so we don't poll the kdevelop.org server every time KDevelop is started (polling like once per day should be totally sufficient)
kfunk updated this object.Jan 11 2017, 12:38 AM
kfunk updated this object.Jan 11 2017, 12:41 AM
apol accepted this revision.Jan 11 2017, 12:43 AM
apol added a reviewer: apol.
kfunk updated this object.Jan 11 2017, 12:44 AM
kfunk removed a reviewer: apol.
apol added a subscriber: apol.Jan 11 2017, 12:45 AM

I doubt it will be a drain to download upon request, especially if it's not shown in the main page...

kfunk updated this object.Jan 11 2017, 1:02 AM
kfunk added a reviewer: KDevelop.
kfunk updated this object.Jan 11 2017, 1:05 AM
kfunk updated this object.
kfunk updated this revision to Diff 10015.Jan 11 2017, 1:35 AM

Changes:

  • Simplify code a bit (no need for printing age actually, we're not a news ticker but just show recent posts)
  • Use locale aware functions to convert date to string
kfunk updated this revision to Diff 10016.Jan 11 2017, 1:50 AM

More cleanup

kfunk updated this revision to Diff 10033.Jan 11 2017, 10:04 AM

Cache news feed entries in storage, only update once per 24 hours

LGTM me now, please review again.

We can probably add a 'disable news' action to the welcome page later, if we want to and in case we get roasted because of the 'calling home' feature ;)

apol accepted this revision.Jan 11 2017, 11:36 AM
apol added a reviewer: apol.

Interesting, first use I see of QtQuick.LocalStorage. :)

This revision is now accepted and ready to land.Jan 11 2017, 11:36 AM
This revision was automatically updated to reflect the committed changes.