Details
Details
- Reviewers
nienhueser - Group Reviewers
Marble - Commits
- R34:be0a39004517: Piste now show up on OSM
Diff Detail
Diff Detail
- Repository
- R34 Marble
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Works fine once I change "piste" to "piste:type". Can you look into that and the other comments?
src/lib/marble/StyleBuilder.cpp | ||
---|---|---|
1231 | This and the ones below should be "piste:type" instead of "piste", no? | |
1878 | has no effect currently, so I'd remove it (or fix it: use a key that takes all dynamic values into account and set cacheSpecialStyle = true) | |
1895 | I think the poly style should be adjusted as well. Some pistes are areas, e.g. the bottom part of Giorgio Rocco in Livigno , see http://www.opensnowmap.org/?zoom=17&lat=46.52527&lon=10.14384 | |
1906 | this is just some outlying islands in oceania, but not all oceanian countries. | |
src/lib/marble/geodata/data/GeoDataPlacemark.cpp | ||
681 | i think "Winter Hike" is more appropriate |