Piste now show up on OSM
ClosedPublic

Authored by Rakete1111 on Jan 9 2017, 6:28 PM.

Details

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Rakete1111 updated this revision to Diff 9942.Jan 9 2017, 6:28 PM
Rakete1111 retitled this revision from to Piste now show up on OSM.
Rakete1111 updated this object.
Rakete1111 edited the test plan for this revision. (Show Details)

Works fine once I change "piste" to "piste:type". Can you look into that and the other comments?

src/lib/marble/StyleBuilder.cpp
1231

This and the ones below should be "piste:type" instead of "piste", no?

1878

has no effect currently, so I'd remove it (or fix it: use a key that takes all dynamic values into account and set cacheSpecialStyle = true)

1895

I think the poly style should be adjusted as well. Some pistes are areas, e.g. the bottom part of Giorgio Rocco in Livigno , see http://www.opensnowmap.org/?zoom=17&lat=46.52527&lon=10.14384

1906

this is just some outlying islands in oceania, but not all oceanian countries.

src/lib/marble/geodata/data/GeoDataPlacemark.cpp
681

i think "Winter Hike" is more appropriate

nienhueser requested changes to this revision.Jan 9 2017, 10:17 PM
nienhueser added a reviewer: Marble.
nienhueser added a project: Marble.
nienhueser added a reviewer: nienhueser.
nienhueser added a subscriber: Marble.
This revision now requires changes to proceed.Jan 9 2017, 10:17 PM
Rakete1111 edited edge metadata.

This should (hopefully) fix the issues raised in the last revision.

This revision was automatically updated to reflect the committed changes.