Differential D4039

Add 'override' keyword only for new standards (BUG 372280)
AbandonedPublic
Actions

Authored by kfunk on Jan 9 2017, 10:20 AM.

Details

Reviewers
denyssenkin
Group Reviewers
KDevelop
Summary

'override' keyword is being added now only if the standards c++11 or c++14 are set for current file.

Diff Detail

Repository
R32 KDevelop
Branch
arcpatch-D4039
Lint
No Linters Available
Unit
No Unit Test Coverage
denyssenkin updated this revision to Diff 9899.Jan 9 2017, 10:20 AM
denyssenkin retitled this revision from to BUG: 372280.
denyssenkin updated this object.
denyssenkin edited the test plan for this revision. (Show Details)
denyssenkin added a reviewer: kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 9 2017, 10:20 AM
denyssenkin retitled this revision from BUG: 372280 to Add 'override' keyword only for new standards (BUG 372280).Jan 9 2017, 10:35 AM
denyssenkin updated this revision to Diff 9902.Jan 9 2017, 10:51 AM

Coding style fixes

kfunk requested changes to this revision.EditedJan 9 2017, 11:40 AM
kfunk edited edge metadata.

Good idea in general. This looks a bit complex for what you try to achieve though.

I think it would be easier if you'd go through KDevelop::IDefinesAndIncludesManager::parserArguments(QString) for figuring out the cpp flags. Did you try that?

This revision now requires changes to proceed.Jan 9 2017, 11:40 AM
kfunk added a comment.Feb 21 2017, 2:12 AM

@denyssenkin Still planning to work on this change?

kfunk commandeered this revision.Nov 15 2018, 1:51 PM
kfunk abandoned this revision.
kfunk edited reviewers, added: denyssenkin; removed: kfunk.

Superseded by: https://phabricator.kde.org/D16773

Revision Contents
Changeset List

Diff 9902

View Options

languages/clang/codecompletion/context.cpp

Loading...