Differential D4035

Set default scope for ProblemStore
ClosedPublic
Actions

Authored by antonanikin on Jan 9 2017, 2:27 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:ae7a1b7b4b97: Set default scope for ProblemStore
R33:ae7a1b7b4b97: Set default scope for ProblemStore
Summary

This commit fixes uninitialized scope value for ProblemStore class. Old version leads to ASSERT during tests run:

QFATAL : TestFilteredProblemStore::testNoGrouping() ASSERT: "d->m_documents" in file /home/jenkins/sources/kdevplatform/kf5-qt5/shell/problemstore.cpp, line 228
FAIL! : TestFilteredProblemStore::testNoGrouping() Received a fatal error.
Test Plan

Tested on master branch.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin updated this revision to Diff 9887.Jan 9 2017, 2:27 AM
antonanikin retitled this revision from to Set default scope for ProblemStore.
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added a reviewer: KDevelop.
antonanikin added a subscriber: kdevelop-devel.
antonanikin updated this object.Jan 9 2017, 2:28 AM
antonanikin updated this object.Jan 9 2017, 2:44 AM
kfunk accepted this revision.Jan 9 2017, 7:43 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

LGTM, will push.

This revision is now accepted and ready to land.Jan 9 2017, 7:43 AM
Closed by commit R33:ae7a1b7b4b97: Set default scope for ProblemStore (authored by antonanikin). · Explain WhyJan 9 2017, 7:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/problemstore.cpp (1 line)

Diff 9893

View Options

shell/problemstore.cpp

Loading...