Remove support for splash screen from Core::initialize(...)
ClosedPublic

Authored by kossebau on Jan 8 2017, 11:48 PM.

Details

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 9884.Jan 8 2017, 11:48 PM
kossebau retitled this revision from to Remove support for splash screen from Core::initialize(...).
kossebau updated this object.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 8 2017, 11:48 PM

Old method signature kept as overload to ease transition for developers not updating both repos at the same time. Useful?

kfunk accepted this revision.Jan 9 2017, 7:54 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Rest LGTM. Should go to master branch.

shell/core.cpp
320 ↗(On Diff #9884)

Style: No spaces in (...)

shell/core.h
66 ↗(On Diff #9884)

Should be before '5.2 release', no?

This patch should go to master branch

This revision is now accepted and ready to land.Jan 9 2017, 7:54 AM
This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.