Ensures internal unit is initialised.
Details
Details
Run kreportexample and ensure page width is as before. Change page size. Open existing reports in Kexi
Diff Detail
Diff Detail
- Repository
- R14 KReport
- Branch
- fixup-qpagelayout
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Would you think it's possible to go for this idea? https://phabricator.kde.org/T4968#73569
Comment Actions
I can if you are certain. I thought because there was only 5 or so cases that it wasnt worth the effort and was better to stick closer to Qt ?
Comment Actions
I am rather certain -- it's centralized change. We will able for example to add an #ifdef for Qt that fixes the issue, once there's one. I propose to add a KReportPrivate::PageLayout class in KReportUtils_p.h.
| src/common/KReportDocument.cpp | ||
|---|---|---|
| 41 | By the way: page -> pageLayout | |
| src/common/KReportUtils_p.h | ||
| 172 | +add //! This class is wrapper that fixes a critical QTBUG-47551 bug in default constructor of QPageLayout //! Default constructor of QPageLayout does not initialize units. //! https://bugreports.qt.io/browse/QTBUG-47551 //! @todo remove this class and go back to QPageLayout when the faulty QPageLayout implementations are no longer on the wild. That's probably for Qt 6. | |
| 174 | For completeness PageLayout(const QPageLayout &pageLayout) could be nice (nonexplicit). | |
Comment Actions
One change left and please push without further review.
| src/common/KReportDocument.cpp | ||
|---|---|---|
| 41 | not done? | |