Fix importing of bookmarks
ClosedPublic
Actions

Authored by Sergobot on Jan 6 2017, 8:08 AM.

Details

Reviewers

nienhueser
rahn

Summary

Also cleared some comments in BookmarkManager.h
Fixes BUG:316969
Related Google Code-In 2016 task:
https://codein.withgoogle.com/dashboard/task-instances/6308606150443008/

Repository

R34 Marble

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Sergobot retitled this revision from to Fix importing of bookmarks.

Sergobot updated this object.

Sergobot added subscribers: nienhueser, rahn.

Check if name provided to folderByName isn't empty

Make importing work with subfolders

src/lib/marble/BookmarkManager.cpp
167	Should check the result here and return it unless it is nullptr, I'd say

Fix issue by @nienhueser

nienhueser edited edge metadata.

This revision is now accepted and ready to land.Jan 12 2017, 9:34 PM

			Path	Packages
M			src/lib/marble/BookmarkManager.h (14 lines)
M			src/lib/marble/BookmarkManager.cpp (23 lines)
M			src/lib/marble/BookmarkManagerDialog.h (4 lines)
M			src/lib/marble/BookmarkManagerDialog.cpp (142 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9790	cb33292		Jan 6 2017, 8:08 AM	★	★
Diff 2	9791	cb33292	Check if name provided to folderByName isn't empty	Jan 6 2017, 8:15 AM	★	★
Diff 3	9807	cb33292	Make importing work with subfolders	Jan 6 2017, 9:49 PM	★	★
Diff 4	9813	cb33292	Fix issue by @nienhueser	Jan 7 2017, 9:17 AM	★	★